Re: Invalid op code emulation for HVM guest and GPF

[Andrew Cooper <andrew.cooper3@citrix.com>]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

Patch attached.

Not tested, but seems logically correct.

@Mukesh: Do you mind testing please?

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com


[-- Attachment #2: x86_emulate_nop.patch --]
[-- Type: text/x-patch, Size: 801 bytes --]

# HG changeset patch
# Parent 0ecb8ffe61b2ffff4331fcf49487c956ccb297a0
x86_emulate: Force #UD if lock prefix used with NOP instruction.

DTRACE uses 0xF0 0x90 0x90 0x90 0x90 (LOCK NOP NOP NOP NOP) to try and recieve a
#UD, but currently get GPF instead.

Fix x86_emulate, as #UD is the correct exception in this case.

Reported-by: Mukesh Rathor <mukesh.rathor@oracle.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

diff -r 0ecb8ffe61b2 xen/arch/x86/x86_emulate/x86_emulate.c
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -2255,6 +2255,7 @@ x86_emulate(
         break;
 
     case 0x90: /* nop / xchg %%r8,%%rax */
+        generate_exception_if(lock_prefix, EXC_UD, -1);
         if ( !(rex_prefix & 1) )
             break; /* nop */
 

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel