From: Andreas Oberritter <obi@opendreambox.org>
To: paul.eggleton@linux.intel.com
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] scripts/bitbake: Allow to override path to pseudodone, make BUILDDIR optional
Date: Fri, 23 Mar 2012 21:20:28 +0100 [thread overview]
Message-ID: <4F6CDB0C.6080809@opendreambox.org> (raw)
In-Reply-To: <1332250625-18091-1-git-send-email-obi@opendreambox.org>
Paul,
how do you propose to go on solving this problem?
Regards,
Andreas
On 20.03.2012 14:37, Andreas Oberritter wrote:
> * Allows to workaround breakage caused by commit
> b4df1c7c79b5c801658bcf890ba3a8eab3d83189.
>
> * Related thread on OE-core mailing list:
> http://lists.linuxtogo.org/pipermail/openembedded-core/2012-March/019136.html
>
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
> ---
> scripts/bitbake | 22 ++++++++++++++++------
> 1 files changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/scripts/bitbake b/scripts/bitbake
> index 45c8697..3377b26 100755
> --- a/scripts/bitbake
> +++ b/scripts/bitbake
> @@ -47,14 +47,24 @@ float_test() {
> # but earlier versions do not
> float_test "$TARVERSION > 1.23" && needtar="0"
>
> -if [ "`pwd`" != "$BUILDDIR" ] ; then
> - echo "BitBake must be run from your build directory: $BUILDDIR"
> +if [ -n "$BUILDDIR" ]; then
> + if [ "`pwd`" != "$BUILDDIR" ] ; then
> + echo "BitBake must be run from your build directory: $BUILDDIR"
> + exit 1
> + fi
> + if [ -z "$PSEUDODONE" ]; then
> + PSEUDODONE="$BUILDDIR/pseudodone"
> + fi
> +fi
> +
> +if [ -z "$PSEUDODONE" ]; then
> + echo "BitBake requires PSEUDODONE to be set."
> exit 1
> fi
>
> buildpseudo="1"
> -if [ $needpseudo = "1" ] && [ -e "$BUILDDIR/pseudodone" ]; then
> - PSEUDOBINDIR=`cat $BUILDDIR/pseudodone`
> +if [ $needpseudo = "1" ] && [ -e "$PSEUDODONE" ]; then
> + PSEUDOBINDIR=`cat $PSEUDODONE`
> if [ -e "$PSEUDOBINDIR/pseudo" -a -e "$PSEUDOBINDIR/tar" -a "$needtar" = "1" ]; then
> buildpseudo="0"
> fi
> @@ -96,7 +106,7 @@ if [ $buildpseudo = "1" ]; then
> if [ "$ret" != "0" ]; then
> exit 1
> fi
> - echo $PSEUDOBINDIR > $BUILDDIR/pseudodone
> + echo $PSEUDOBINDIR > $PSEUDODONE
> # This needs to exist in case pseudo has to log somewhere
> mkdir -p $PSEUDOBINDIR/../../var/pseudo
> fi
> @@ -104,7 +114,7 @@ BITBAKE=`which bitbake`
> export PATH=$OLDPATH
> if [ $needpseudo = "1" ]; then
> export PSEUDO_BUILD=2
> - PSEUDOBINDIR=`cat $BUILDDIR/pseudodone`
> + PSEUDOBINDIR=`cat $PSEUDODONE`
> PSEUDO_BINDIR=$PSEUDOBINDIR PSEUDO_LIBDIR=$PSEUDOBINDIR/../lib/pseudo/lib PSEUDO_PREFIX=$PSEUDOBINDIR/../../ PSEUDO_DISABLED=1 $PSEUDOBINDIR/pseudo $BITBAKE $@
> else
> export PSEUDO_BUILD=0
next prev parent reply other threads:[~2012-03-23 20:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 13:37 [PATCH] scripts/bitbake: Allow to override path to pseudodone, make BUILDDIR optional Andreas Oberritter
2012-03-23 20:20 ` Andreas Oberritter [this message]
2012-03-26 10:07 ` Paul Eggleton
2012-03-26 10:29 ` Andreas Oberritter
2012-03-26 14:38 ` Andreas Oberritter
2012-03-26 14:48 ` Paul Eggleton
2012-03-26 14:57 ` Andreas Oberritter
2012-03-26 15:09 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6CDB0C.6080809@opendreambox.org \
--to=obi@opendreambox.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.