Re: [PATCH 3/9] lib/bb/ui/crumbs/recipeselectionpage: add 'Build image' button per design

[Joshua Lock <josh@linux.intel.com>]

On 23/03/12 17:32, Xu, Dongxiao wrote:
> On Fri, 2012-03-23 at 17:23 -0700, Joshua Lock wrote:
>> The design calls for the 'Build packages' button to be a secondary action
>> and a 'Build image' primary action to exist on the recipe selection page.
>
> Sorry, I think this design doesn't make sense.
>
> Thinking of this scenario, if a user clicks "Create your own image" in
> base image drop down list, and then clicks "View Recipes" to select some
> recipes, if we allow user to directly click "Build image" here, it is
> wrong since nothing has been set to PACKAGE_INSTALL variable and the
> image build will fail.
>
> Also it will confuse user that, they would think what they selected in
> the recipe page will be packed into the final image, however it isn't.
> Therefore I suggest removing the "build image" button in recipe
> selection page.

Hmm, I missed that but sounds like it doesn't make sense to include this 
patch as is.

I guess we need to either:
a) Change the 'Build packages' button to be the primary action. A simple 
change to ensure a consistent GUI.
b) Figure out some logic for mapping the selected recipes to packages in 
the case of the user clicking the 'Build image' button.

I would imagine a) makes most sense for the 1.2 timeframe?

Cheers,
Joshua
-- 
Joshua '贾詡' Lock
         Yocto Project "Johannes factotum"
         Intel Open Source Technology Centre