From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Emre Ersin <emre.ersin@gmail.com>
Subject: Re: [Qemu-devel] [Patch 0/2] Fix QEMU configure / make with Turkish (and maybe other) locale
Date: Sun, 25 Mar 2012 21:27:31 +0200 [thread overview]
Message-ID: <4F6F71A3.5020603@suse.de> (raw)
In-Reply-To: <1332702671-32076-1-git-send-email-sw@weilnetz.de>
Am 25.03.2012 21:11, schrieb Stefan Weil:
> These two patches override the user specific locale settings which
> can break QEMU builds. They set the default locale C for configure
> and make:
>
> [PATCH v2 1/2] Makefile: Set default locale C
> [PATCH 2/2] configure: Set default locale C (fix build for Turkish
>
> A side effect is that all messages which are produced during configure
> and make also use the default locale, so for example compiler messages
> are no longer localized.
Reading the patches I thought of that issue, too, and don't think a
sledge hammer is the best solution here. The issue reported was tr (a
user-invisible invokation) misbehaving so why not fix just that? That
way user-directed output would still be in the language of the user's
choice.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-03-25 19:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-25 19:11 [Qemu-devel] [Patch 0/2] Fix QEMU configure / make with Turkish (and maybe other) locale Stefan Weil
2012-03-25 19:11 ` [Qemu-devel] [PATCH v2 1/2] Makefile: Set default locale C Stefan Weil
2012-03-25 19:11 ` [Qemu-devel] [PATCH 2/2] configure: Set default locale C (fix build for Turkish locale) Stefan Weil
2012-03-25 19:27 ` Andreas Färber [this message]
2012-03-25 19:48 ` [Qemu-devel] [Patch 0/2] Fix QEMU configure / make with Turkish (and maybe other) locale Stefan Weil
2012-03-26 19:25 ` Eric Blake
2012-03-25 19:52 ` Peter Maydell
2012-03-25 20:16 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6F71A3.5020603@suse.de \
--to=afaerber@suse.de \
--cc=emre.ersin@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.