From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBtrf-0001Rl-9u for qemu-devel@nongnu.org; Sun, 25 Mar 2012 16:16:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SBtrd-00081A-Hd for qemu-devel@nongnu.org; Sun, 25 Mar 2012 16:16:34 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:36987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBtrd-000816-Ar for qemu-devel@nongnu.org; Sun, 25 Mar 2012 16:16:33 -0400 Message-ID: <4F6F7D1E.1080508@weilnetz.de> Date: Sun, 25 Mar 2012 22:16:30 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1332702671-32076-1-git-send-email-sw@weilnetz.de> <4F6F71A3.5020603@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Patch 0/2] Fix QEMU configure / make with Turkish (and maybe other) locale List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Emre Ersin , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Am 25.03.2012 21:52, schrieb Peter Maydell: > On 25 March 2012 20:27, Andreas F=C3=A4rber wrote: >> Am 25.03.2012 21:11, schrieb Stefan Weil: >>> These two patches override the user specific locale settings which >>> can break QEMU builds. They set the default locale C for configure >>> and make: >>> >>> [PATCH v2 1/2] Makefile: Set default locale C >>> [PATCH 2/2] configure: Set default locale C (fix build for Turkish >>> >>> A side effect is that all messages which are produced during configur= e >>> and make also use the default locale, so for example compiler message= s >>> are no longer localized. >> >> Reading the patches I thought of that issue, too, and don't think a >> sledge hammer is the best solution here. The issue reported was tr (a >> user-invisible invokation) misbehaving so why not fix just that? That >> way user-directed output would still be in the language of the user's >> choice. > > Well, configure should just set the locale to C, I think. This is how > autoconf-generated configure scripts behave, for example. The rationale > here is that configure shouldn't be outputting anything except (a) outp= ut > to log files etc and (b) messages we control [and which we don't locali= se > anyway!]. So we should favour not making it easy to accidentally > introduce obscure bugs in some locales. I fully agree. > > For make itself the argument is less clear-cut because as you say > compiler messages go to the user. > > -- PMM For make, it is still possible to set LANGUAGE. I don't know whether it works with gcc (none of my native and cross gcc installations has localized messages installed), but I tested setting LANGUAGE with 'ls --help' where it works. And compiler messages go first to the user, but sometimes also to other developers (bug reports!), so even there are good arguments for the C locale. Regards, Stefan W.