All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Big endian fixes for btrfs
Date: Sun, 25 Mar 2012 23:29:23 +0200	[thread overview]
Message-ID: <4F6F8E33.4030700@gmail.com> (raw)
In-Reply-To: <20120326081008.37315b3c@kryten>

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

On 25.03.2012 23:10, Anton Blanchard wrote:
> -  data->inode = key_in.object_id;
> +  data->inode = grub_le_to_cpu64 (key_in.object_id);
the inode field is in little-endian as well (not native endian)

>-         if (key_out.object_id != ino
>+         if (grub_le_to_cpu64 (key_out.object_id) != ino

Not if you keep both sides little-endian

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

  reply	other threads:[~2012-03-25 21:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-25 13:36 [PATCH] Big endian fixes for btrfs Anton Blanchard
2012-03-25 13:47 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-03-25 21:10   ` Anton Blanchard
2012-03-25 21:29     ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2012-03-25 22:20       ` [PATCH v2] " Anton Blanchard
2012-03-31 20:14 ` [PATCH] " Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6F8E33.4030700@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.