Re: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card

[Stephen Boyd <sboyd@codeaurora.org>]

On 3/22/2012 10:56 PM, Subhash Jadavani wrote:
> @@ -296,6 +297,28 @@ int mmc_add_card(struct mmc_card *card)
>  		break;
>  	}
>  
> +	if (mmc_sd_card_uhs(card)) {
> +		switch (card->sd_bus_speed) {
> +		case UHS_SDR104_BUS_SPEED:
> +			uhs_bus_speed_mode = "SDR104 ";
> +			break;
> +		case UHS_SDR50_BUS_SPEED:
> +			uhs_bus_speed_mode = "SDR50 ";
> +			break;
> +		case UHS_DDR50_BUS_SPEED:
> +			uhs_bus_speed_mode = "DDR50 ";
> +			break;
> +		case UHS_SDR25_BUS_SPEED:
> +			uhs_bus_speed_mode = "SDR25 ";
> +			break;
> +		case UHS_SDR12_BUS_SPEED:
> +			uhs_bus_speed_mode = "SDR12 ";
> +			break;
> +		default:
> +			uhs_bus_speed_mode = "";
> +			break;
> +		}
>

This could be better code with an array:

static char *speeds[] = {
	[UHS_SDR104_BUS_SPEED] = "SDR104",
 	[UHS_SDR50_BUS_SPEED] = "SDR50",
	[UHS_SDR50_BUS_SPEED] = "DDR50",
	...
};  

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.