From: Stephen Warren <swarren@wwwdotorg.org>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: dmitry.torokhov@gmail.com, rajeev-dlh.kumar@st.com,
devicetree-discuss@lists.ozlabs.org, spear-devel@list.st.com,
viresh.linux@gmail.com, linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: spear-keyboard: add device tree bindings
Date: Mon, 26 Mar 2012 09:30:23 -0600 [thread overview]
Message-ID: <4F708B8F.10602@wwwdotorg.org> (raw)
In-Reply-To: <a2d16bc563cf5c7e8eebf817de0a1eb08d7b96ba.1332754641.git.viresh.kumar@st.com>
On 03/26/2012 03:45 AM, Viresh Kumar wrote:
> This adds simple DT bindings for spear-keyboard controller.
...
> diff --git a/Documentation/devicetree/bindings/input/spear-keyboard.txt b/Documentation/devicetree/bindings/input/spear-keyboard.txt
...
> +Required properties:
> +- compatible: "st,spear-kbd"
Should "spear" include some version number so that there's a clear path
if/when future SoCs need a different binding?
> +Optional properties, in addition to those specified by the shared
> +matrix-keyboard bindings:
> +- autorepeat: bool: enables key autorepeat
> +- mode: keyboard mode: 0 - 9x9, 1 - 6x6, 2 - 2x2
mode at least should be "st,mode". autorepeat is probably generic enough
that it doesn't need the vendor prefix.
next prev parent reply other threads:[~2012-03-26 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 9:45 [PATCH 1/2] input/of_keymap: Convert kzalloc to devm_kzalloc derivative Viresh Kumar
2012-03-26 9:45 ` [PATCH 2/2] Input: spear-keyboard: add device tree bindings Viresh Kumar
2012-03-26 15:30 ` Stephen Warren [this message]
[not found] ` <4F708B8F.10602-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-26 15:35 ` viresh kumar
2012-03-26 15:26 ` [PATCH 1/2] input/of_keymap: Convert kzalloc to devm_kzalloc derivative Stephen Warren
2012-03-26 15:55 ` Dmitry Torokhov
2012-03-27 4:18 ` spear devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F708B8F.10602@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=rajeev-dlh.kumar@st.com \
--cc=spear-devel@list.st.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.