From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Daniel Drake <dsd@laptop.org>,
mingo@redhat.com, tglx@linutronix.de, x86@kernel.org,
linux-kernel@vger.kernel.org, dilinger@queued.net,
pgf@laptop.org
Subject: Re: [PATCH v4] x86, olpc: add debugfs interface for EC commands
Date: Mon, 26 Mar 2012 14:31:46 -0700 [thread overview]
Message-ID: <4F70E042.4020703@zytor.com> (raw)
In-Reply-To: <20120326142908.c5248aec.akpm@linux-foundation.org>
On 03/26/2012 02:29 PM, Andrew Morton wrote:
>>
>> v4: really fix sign-off tags
>
> s/fix/break/? "Originally-from" is not a recognised tag. If this code
> is based upon an earlier version from Paul then Signed-off-by: is
> correct.
>
> What's going on here? What are you trying to communicate?
I have been using "Originally-by:" (not Originally-from:) to indicate
content originally written by someone else which has then been
dramatically redone. It seems to communicate, but probably should be
written into a spec somewhere.
It doesn't make much sense to put that after a Signed-off-by: though
(lines are supposed to be in chronological order.)
-hpa
next prev parent reply other threads:[~2012-03-26 21:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 18:07 [PATCH v4] x86, olpc: add debugfs interface for EC commands Daniel Drake
2012-03-26 21:29 ` Andrew Morton
2012-03-26 21:31 ` H. Peter Anvin [this message]
2012-03-26 21:51 ` Andrew Morton
2012-03-27 16:07 ` Matthew Garrett
2012-03-27 16:18 ` Valdis.Kletnieks
2012-03-26 22:13 ` Paul Fox
2012-03-26 22:45 ` Daniel Drake
2012-03-26 22:47 ` H. Peter Anvin
2012-03-26 23:05 ` Andrew Morton
2012-03-26 22:53 ` Andrew Morton
2012-03-26 23:57 ` Andres Salomon
2012-03-26 23:14 ` Ingo Molnar
2012-03-26 23:23 ` Andrew Morton
2012-03-26 23:49 ` Ingo Molnar
2012-03-27 4:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F70E042.4020703@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=dsd@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pgf@laptop.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.