Re: [PATCH v2] Avoid OOPS when reshaping raid1 to raid0

[Jes Sorensen <Jes.Sorensen@redhat.com>]

On 03/27/12 05:35, NeilBrown wrote:
> On Mon, 26 Mar 2012 10:31:25 +0200 Jes.Sorensen@redhat.com wrote:
> 
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> raid1 arrays do not have the notion of chunk size. Calculate the
>> larges chunk sector size we can use to avoid a divide by zero OOPS
>> when aligning the size of the new array to the chunk size.
>>
>> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> 
> Thanks.
> Applied with one change:
> 
>>  	/* Set new parameters */
>>  	mddev->new_level = 0;
>>  	mddev->new_layout = 0;
>>  	mddev->new_chunk_sectors = 128; /* by default set chunk size to 64k */
> 
> I changed the above line to
> 	mddev->new_chunk_sectors = chunksect;
> 
> as that makes more sense.

I agree, I was wondering whether to change it as well.

Thanks - will it be in your git repo soon?

Cheers,
Jes