From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] qerror: Add QERR_PROPERTY_SET_AFTER_REALIZE
Date: Tue, 27 Mar 2012 09:27:05 +0200 [thread overview]
Message-ID: <4F716BC9.5040304@redhat.com> (raw)
In-Reply-To: <4F708FB9.6000507@suse.de>
Il 26/03/2012 17:48, Andreas Färber ha scritto:
> Am 26.03.2012 17:30, schrieb Peter Maydell:
>> Add a new QError QERR_PROPERTY_SET_AFTER_REALIZE for attempts
>> to set a QOM or qdev property after the object/device has been
>> realized. This allows a slightly more informative diagnostic
>> than the previous "Insufficient permission" message.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> We've talked about the rather unhelpful nature of the "Insufficient
>> permission" diagnostic before:
>> http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02368.html
>> and I finally got round to writing a patch to improve it...
>
> Not aware of the submission, I suggested to append this to my series,
> since upstream does not yet have "realize" as such.
Yes, good idea.
>> +#define QERR_PROPERTY_SET_AFTER_REALIZE \
>> + "{ 'class': 'PropertySetAfterRealize', 'data': { 'device': %s, 'property': %s } }"
>
> Properties are no longer a device concept. Can we start using a
> different key name here, e.g., 'type'?
Too late I guess, I prefer consistency.
Paolo
prev parent reply other threads:[~2012-03-27 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 15:30 [Qemu-devel] [PATCH] qerror: Add QERR_PROPERTY_SET_AFTER_REALIZE Peter Maydell
2012-03-26 15:48 ` Andreas Färber
2012-03-27 7:27 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F716BC9.5040304@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.