From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SCRGL-0002hA-Oi
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 03:56:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SCRGF-0006uI-B9
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 03:56:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7373)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SCRGF-0006tx-36
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 03:56:11 -0400
Message-ID: <4F716BC9.5040304@redhat.com>
Date: Tue, 27 Mar 2012 09:27:05 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1332775847-29202-1-git-send-email-peter.maydell@linaro.org>
	<4F708FB9.6000507@suse.de>
In-Reply-To: <4F708FB9.6000507@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qerror: Add QERR_PROPERTY_SET_AFTER_REALIZE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, patches@linaro.org

Il 26/03/2012 17:48, Andreas F=E4rber ha scritto:
> Am 26.03.2012 17:30, schrieb Peter Maydell:
>> Add a new QError QERR_PROPERTY_SET_AFTER_REALIZE for attempts
>> to set a QOM or qdev property after the object/device has been
>> realized. This allows a slightly more informative diagnostic
>> than the previous "Insufficient permission" message.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> We've talked about the rather unhelpful nature of the "Insufficient
>> permission" diagnostic before:
>> http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02368.html
>> and I finally got round to writing a patch to improve it...
>=20
> Not aware of the submission, I suggested to append this to my series,
> since upstream does not yet have "realize" as such.

Yes, good idea.

>> +#define QERR_PROPERTY_SET_AFTER_REALIZE \
>> +    "{ 'class': 'PropertySetAfterRealize', 'data': { 'device': %s, 'p=
roperty': %s } }"
>=20
> Properties are no longer a device concept. Can we start using a
> different key name here, e.g., 'type'?

Too late I guess, I prefer consistency.

Paolo