From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47835)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SCRdE-0002QE-Hx
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 04:19:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SCRd8-00052Z-0B
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 04:19:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48663)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SCRd7-00052J-OQ
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 04:19:49 -0400
Message-ID: <4F71780B.3070103@redhat.com>
Date: Tue, 27 Mar 2012 10:19:23 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1332740423-8426-1-git-send-email-zwu.kernel@gmail.com>
	<CAJSP0QW1LA7rPbvwAGf4AF1S9LEJMfOnhY-r0bgE5kvOkun0Lw@mail.gmail.com>
	<CAEH94LgmidfmBM6E-p=-cAtygEnaCpeCMC-h26eHCXdnv1JEbw@mail.gmail.com>
In-Reply-To: <CAEH94LgmidfmBM6E-p=-cAtygEnaCpeCMC-h26eHCXdnv1JEbw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 0/9] QOM: qomify -netdev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

Il 26/03/2012 16:20, Zhi Yong Wu ha scritto:
> struct PropertyInfo {
>     const char *name;
>     const char *legacy_name;
>     const char **enum_table;
>     int64_t min;
>     int64_t max;
>     int (*parse)(DeviceState *dev, Property *prop, const char *str);
>     int (*print)(DeviceState *dev, Property *prop, char *dest, size_t len);
>     ObjectPropertyAccessor *get;
>     ObjectPropertyAccessor *set;
>     ObjectPropertyRelease *release;
> };
> 
> Like above, its member functions pointers use DeviceState, so we will
> have to consider how to make this PropertyInfo more generic and be
> used by other Class and Object which are not based on DeviceState.

The member functions do not really do anything that is
DeviceState-specific.  You can change the argument to Object and add a
cast inside the implementations.

Besides, most property types do not have parse/print anymore.  Another
possibility would be to forbid hexNN types for non-DeviceState, since
only those have parse/print.

Paolo