From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58749)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SCSQM-0000NE-Ms
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 05:10:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SCSQI-0001yM-2w
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 05:10:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39324)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SCSQH-0001y8-R5
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 05:10:38 -0400
Message-ID: <4F717A9B.6060804@redhat.com>
Date: Tue, 27 Mar 2012 10:30:19 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1332740423-8426-1-git-send-email-zwu.kernel@gmail.com>
	<1332740423-8426-5-git-send-email-zwu.kernel@gmail.com>
In-Reply-To: <1332740423-8426-5-git-send-email-zwu.kernel@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 2/9] net: introduce one net host device class
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: zwu.kernel@gmail.com
Cc: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

Il 26/03/2012 07:40, zwu.kernel@gmail.com ha scritto:
> +    /*< public >*/
> +    QemuOpts *opts;
> +    Monitor *mon;
> +    const char *name;
> +    NetClientState *peer;
> +};

The QemuOpts should not be part of the struct.  You need to store them
into properties at initialization time, and forget them afterwards.

All the infrastructure to do this is already in qdev-properties.c.

Paolo