From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Lee Essen <lee.essen@nowonline.co.uk>,
Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: fix mingw32 libs_qga typo
Date: Tue, 27 Mar 2012 16:19:20 +0200 [thread overview]
Message-ID: <4F71CC68.6000909@suse.de> (raw)
In-Reply-To: <1332833178-18521-1-git-send-email-stefanha@linux.vnet.ibm.com>
Am 27.03.2012 09:26, schrieb Stefan Hajnoczi:
> It's typical to prepend or append parameters to an argument string so
> that other places in ./configure can add parameters without clobbering
> the string. In the mingw32 libs_qga case there is a typo "$lib_qga"
> instead of "$libs_qga".
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
> ---
> configure | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 14ef738..d63c011 100755
> --- a/configure
> +++ b/configure
> @@ -526,7 +526,7 @@ EOF
> bindir="\${prefix}"
> sysconfdir="\${prefix}"
> confsuffix=""
> - libs_qga="-lws2_32 -lwinmm -lpowrprof $lib_qga"
> + libs_qga="-lws2_32 -lwinmm -lpowrprof $libs_qga"
> fi
>
> werror=""
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-03-27 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 7:26 [Qemu-devel] [PATCH] configure: fix mingw32 libs_qga typo Stefan Hajnoczi
2012-03-27 14:19 ` Andreas Färber [this message]
2012-03-27 14:49 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F71CC68.6000909@suse.de \
--to=afaerber@suse.de \
--cc=lee.essen@nowonline.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.