All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wido den Hollander <wido@widodh.nl>
To: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Unmount btrfs when stopping OSD's
Date: Tue, 27 Mar 2012 16:20:45 +0200	[thread overview]
Message-ID: <4F71CCBD.4070501@widodh.nl> (raw)

Hi,

It's something I noticed some time ago, but never really paid attention to.

When we start an OSD we automatically mount the btrfs filesystem if 
"btrfs devs" is set, but we do not unmount when we stop the OSD.

I see the init script is prepared for this:

dobtrfsumount=0
..
     --btrfsumount)
	    dobtrfsumount=1
..
if [ $dobtrfsumount -eq 1 ] && [ -n "$btrfs_devs" ]; then

Why would this be set to 0 by default? Any reason?

I like my daemons/init scripts to clean up their 'mess' when they stop.

I'd vote for setting this to 1 by default.

Wido

             reply	other threads:[~2012-03-27 14:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27 14:20 Wido den Hollander [this message]
2012-03-27 18:50 ` Unmount btrfs when stopping OSD's Tommi Virtanen
2012-03-27 19:09   ` Wido den Hollander
2012-03-27 19:25     ` Tommi Virtanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F71CCBD.4070501@widodh.nl \
    --to=wido@widodh.nl \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.