From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCYbb-00048L-9y for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:46:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCYbZ-0004ec-7x for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:46:42 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:46972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCYbY-0004dt-VN for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:46:41 -0400 Received: by pbcuo5 with SMTP id uo5so460587pbc.4 for ; Tue, 27 Mar 2012 08:46:38 -0700 (PDT) Sender: Richard Henderson Message-ID: <4F71E0DA.4050204@twiddle.net> Date: Tue, 27 Mar 2012 08:46:34 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1332840290-24553-1-git-send-email-proljc@gmail.com> <1332840290-24553-4-git-send-email-proljc@gmail.com> In-Reply-To: <1332840290-24553-4-git-send-email-proljc@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 03/12] Add MIPS DSP Branch instruction Support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jia Liu Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On 03/27/12 02:24, Jia Liu wrote: > Add MIPS DSP Branch instruction Support. > > Signed-off-by: Jia Liu Reviewed-by: Richard Henderson > + case OPC_BPOSGE32: > + tcg_gen_setcondi_tl(TCG_COND_GT, bcond, t0, 31); Nit: It might be better to use TCG_COND_GE ... 32, since that's both the name of the insn and its official documentation. Of course that makes no difference to the correctness. r~