From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33320)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1SCYer-00084L-Iz
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:50:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1SCYem-0005hJ-Ta
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:50:05 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:36754)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1SCYem-0005gq-Jc
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:50:00 -0400
Received: by pbcuo5 with SMTP id uo5so464437pbc.4
	for <qemu-devel@nongnu.org>; Tue, 27 Mar 2012 08:49:58 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4F71E1A4.4020602@twiddle.net>
Date: Tue, 27 Mar 2012 08:49:56 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1332840290-24553-1-git-send-email-proljc@gmail.com>
	<1332840290-24553-5-git-send-email-proljc@gmail.com>
In-Reply-To: <1332840290-24553-5-git-send-email-proljc@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V3 04/12] Add MIPS DSP Load instructions
 Support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jia Liu <proljc@gmail.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net

On 03/27/12 02:24, Jia Liu wrote:
> +DEF_HELPER_2(lbux, tl, tl, int)
> +DEF_HELPER_2(lhx, i32, i32, int)
> +DEF_HELPER_2(lwx, i32, i32, int)

These should not be helpers.  They are exactly the qemu_ld{8,16,32}u opcodes.


r~