From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Mathieu_Gagn=E9?= <mgagne@iweb.com>
Subject: xl: Need help with overflow and error handling for vif
	rate support
Date: Tue, 27 Mar 2012 13:04:45 -0400
Message-ID: <4F71F32D.9080601@iweb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Hi,

I'm working a patch to add support for vif rate limiting support to 
libxl/xl. [1]

I'm especially working on using uint64_t instead of uint32_t [2] and 
adding error handling. [3]

- How should I check for overflows when multiplying 2 uint64_t together?
   - I'm currently using math.h and log. Is it the correct approach?
- How should I handle errors?
   - Should I do something similar to libxlu_disk.c?
   - Should xlu_vif_parse_rate prints an error and returns an error code?
   - If the error is from one of the "helpers", should they print an 
error too or should xlu_vif_parse_rate deals with it?

Any help would be greatly appreciated.

Regards,

[1] http://lists.xen.org/archives/html/xen-devel/2012-03/msg01596.html
[2] http://lists.xen.org/archives/html/xen-devel/2012-03/msg01627.html
[3] http://lists.xen.org/archives/html/xen-devel/2012-03/msg01738.html

-- 
Mathieu