Re: [PATCH] [SCSI] be2iscsi: Remove unused OFFSET_IN_PAGE() macro

[Mike Christie <michaelc@cs.wisc.edu>]

On 03/27/2012 11:38 AM, Roland Dreier wrote:
> On Wed, Feb 29, 2012 at 10:41 PM, Roland Dreier <roland@kernel.org> wrote:
>> From: Roland Dreier <roland@purestorage.com>
>>
>> Signed-off-by: Roland Dreier <roland@purestorage.com>
>> ---
>>  drivers/scsi/be2iscsi/be.h |    4 ----
>>  1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/scsi/be2iscsi/be.h b/drivers/scsi/be2iscsi/be.h
>> index 1d7b976..a50b6a9 100644
>> --- a/drivers/scsi/be2iscsi/be.h
>> +++ b/drivers/scsi/be2iscsi/be.h
>> @@ -132,10 +132,6 @@ struct be_ctrl_info {
>>                ((u32)((((size_t)(_address) & (PAGE_SIZE_4K - 1)) +     \
>>                        (size) + (PAGE_SIZE_4K - 1)) >> PAGE_SHIFT_4K))
>>
>> -/* Byte offset into the page corresponding to given address */
>> -#define OFFSET_IN_PAGE(addr)                                           \
>> -               ((size_t)(addr) & (PAGE_SIZE_4K-1))
>> -
>>  /* Returns bit offset within a DWORD of a bitfield */
>>  #define AMAP_BIT_OFFSET(_struct, field)                                        \
>>                (((size_t)&(((_struct *)0)->field))%32)
> 
> ping?  the corresponding be2net patch is upstream as 97767a87f3be.
> 

Jay probably missed it, because he has been sick. Looks good to me.

Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>