From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48536)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SCdRX-0004e3-7L
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 16:56:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SCdRV-0000ys-Eu
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 16:56:38 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:55259)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SCdRV-0000yY-8Y
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 16:56:37 -0400
Message-ID: <4F722982.5020303@weilnetz.de>
Date: Tue, 27 Mar 2012 22:56:34 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1331751444-30905-1-git-send-email-sw@weilnetz.de>
	<4F60ECB4.6050006@redhat.com> <4F610431.7090005@weilnetz.de>
In-Reply-To: <4F610431.7090005@weilnetz.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Fix call syntax for
	qemu-img
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org

Am 14.03.2012 21:48, schrieb Stefan Weil:
> Am 14.03.2012 20:08, schrieb Eric Blake:
>> On 03/14/2012 12:57 PM, Stefan Weil wrote:
>>> qemu-img requires first options, then file name, then size.
>>>
>>> GNU getopt also allows options at the end, but POSIX getopt
>>> doesn't. Try "export POSIXLY_CORRECT=y" to get the POSIX
>>> behaviour with GNU getopt, too.
>>
>> That's a heavy sledgehammer, that has the potential to affect a lot of
>> other programs called alongside qemu-img. Simpler would be to just pass
>> -- in the command line at the point where you want to force qemu to
>> treat all further arguments without getopt reordering them, as in:
>
> I did not want to suggest that POSIXLY_CORRECT should always
> be set. It's just a way how maintainers can test that there is
> a problem with the current code, and that this problem is
> fixed by my patch.
>
> Passing -- in the command line will not only stop argument
> reordering, it also stops argument parsing which is not
> what we need here.
>
> Regards,
>
> Stefan W.

Ping? These two patches for qemu-iotests are still missing
in QEMU git master. Are there any open questions, or can
they be committed? Should they go through qemu-trivial?

Cheers,
Stefan W.