All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathias Weber <mweb@gmx.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
	git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH] tag: add --author option
Date: Tue, 27 Mar 2012 23:11:52 +0200	[thread overview]
Message-ID: <4F722D18.50502@gmx.ch> (raw)
In-Reply-To: <7vr4wdhilj.fsf@alter.siamese.dyndns.org>

On 27.03.2012 22:52, Junio C Hamano wrote:
> Mathias Weber <mweb@gmx.ch> writes:
> 
>> On 27.03.2012 19:29, Zbigniew Jędrzejewski-Szmek wrote:
>>> On 03/27/2012 06:00 PM, Mathias Weber wrote:
>>>>
>>>> The tag command does not support the --author option as the
>>>> commit command. This adds the --author option to create
>>>> annotated tags with a different author.
>>>
>>> Consistency is good.
>>
>> It would be good but during the rework of the patch I realized that for
>> the tag the committer is and should be used and not the author.
>> Therefore it is fine that this option isn't available. I'm sorry
>> bothering you.
> 
> I would have thought that being able to lie about "tagger " would be
> equivalent to lying about --author of the commit.  What am I missing?
> 
> Not that I am enthused by the idea of having to add another option.  I
> would be perfectly happy if we did not add such a flag.  It is just I do
> not understand the reasoning behind the retraction.
> 

Yes this was what I first though as well but isn't the tagger similar to
the committer? With the --author option we change only the author of a
commit and not the committer. To change the committer you have to
provide the env variable GIT_COMMITTER_NAME and GIT_COMMITER_EMAIL or
change the config file. I haven't found a option to change the
committer. I think the tagger is about the same as the committer. It
make sens to have a committer and an author for a commit and this might
not even be the same person but for a tag there is only the tagger.
Which is the person how makes the tag.

Mathias

  reply	other threads:[~2012-03-27 21:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27 16:00 [PATCH] tag: add --author option Mathias Weber
2012-03-27 17:29 ` Zbigniew Jędrzejewski-Szmek
2012-03-27 20:32   ` Mathias Weber
2012-03-27 20:52     ` Junio C Hamano
2012-03-27 21:11       ` Mathias Weber [this message]
2012-03-27 23:05         ` Junio C Hamano
2012-03-27 20:42   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F722D18.50502@gmx.ch \
    --to=mweb@gmx.ch \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=zbyszek@in.waw.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.