All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dgilbert@interlog.com>
To: linux-scsi@vger.kernel.org
Subject: scsi_check_sense() interfering with pass-through SCSI calls
Date: Tue, 27 Mar 2012 17:13:10 -0400	[thread overview]
Message-ID: <4F722D66.8070702@interlog.com> (raw)

I have been sent an example of sg_verify giving strange results
in BYTCHK mode. A bus analyzer is showing a properly formed
sense buffer with a sense_key of MISCOMPARE. In lk 3.3.0
scsi_check_sense() is detecting this case and setting
DID_TARGET_ERROR. For a pass-through call originating from
the sg or bsg driver that is unwelcome interference.

Since users of a SCSI command pass-through should be
checking the SCSI status and sense buffer, then commands
issued by the bsg and sg driver (probably st as well)
should not be calling scsi_check_sense() IMO.

Doug Gilbert


                 reply	other threads:[~2012-03-27 21:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F722D66.8070702@interlog.com \
    --to=dgilbert@interlog.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.