From: Clemens Ladisch <clemens@ladisch.de>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jason Baron <jbaron@redhat.com>,
Jim Cromie <jim.cromie@gmail.com>, Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [RFC] Remove most all #define pr_fmt(fmt) lines
Date: Wed, 28 Mar 2012 09:27:11 +0200 [thread overview]
Message-ID: <4F72BD4F.9020305@ladisch.de> (raw)
In-Reply-To: <1332869030.2213.46.camel@joe2Laptop>
Joe Perches wrote:
> With this change, objects like drivers/regulator/core.o
> are prefixed with "core: ". This is somewhat senseless
> and may prompt Makefile changes to make the prefixes for
> some objects more sensible.
>
> For example, modifying the Makefile to bundle objects
> together with a specific name can change the prefixes.
> Here the prefix becomes "regulator: "
>
> +++ b/drivers/regulator/Makefile
>
> +regulator-y := core.o dummy.o fixed-helper.o
> +regulator-objs := $(regulator-y)
>
> -obj-$(CONFIG_REGULATOR) += core.o dummy.o fixed-helper.o
> +obj-$(CONFIG_REGULATOR) += regulator.o
>
> ------------------
>
> Any objections or other suggestions/improvements?
Instead of doing a Makefile change that has no _obvious_ connection with
printk, wouldn't it be better to just define pr_fmt with "regulator: "?
Regards,
Clemens
next prev parent reply other threads:[~2012-03-28 7:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 17:23 [RFC] Remove most all #define pr_fmt(fmt) lines Joe Perches
2012-03-28 7:27 ` Clemens Ladisch [this message]
2012-03-28 7:30 ` Joe Perches
2012-03-28 9:46 ` Mark Brown
2012-03-28 16:22 ` Joe Perches
2012-03-28 16:33 ` Mark Brown
2012-03-28 7:42 ` Geert Uytterhoeven
2012-03-28 8:03 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F72BD4F.9020305@ladisch.de \
--to=clemens@ladisch.de \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jbaron@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.