From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] misc:pmic: Support for voltage to register value conversion function
Date: Wed, 28 Mar 2012 14:50:35 +0200 [thread overview]
Message-ID: <4F73091B.4000708@denx.de> (raw)
In-Reply-To: <20120328143820.44ca652c@lmajewski.digital.local>
On 28/03/2012 14:38, Lukasz Majewski wrote:
> Hi Stefano,
>
Hi Lucasz,
> I've already forwarded those patches to you.
> They are also available on the mailing list, so I don't know what has
> happened.
Really nothing, I got all e-mails, I was only not able to explain my doubt.
I try again:
- In patch 1/3 you add voltage_to_reg to the pmic struct
==> Ok
- in patch 2/3 you add voltage_to_reg to MAX8997.
==> Ok
Everything clear.
The consequence for me is that PATCH 3/3 shows the reason to add
voltage_to_reg(), and calls the new function pmic_vol_to_reg(), because
you need it, as you have already explained. But I see only
pmic_set_output() and pmic_reg_write() in your patch.
What have I not yet understood ? (maybe I need a coffe to wake up my
brain...)
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2012-03-28 12:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 8:45 [U-Boot] [PATCH 1/3] misc:pmic: Support for voltage to register value conversion function Lukasz Majewski
2012-03-28 8:45 ` [U-Boot] [PATCH 2/3] misc:pmic:max8997 MAX8997 support for PMIC driver Lukasz Majewski
2012-03-28 8:45 ` [U-Boot] [PATCH 3/3] misc:pmic:samsung Convert TRATS target to use MAX8997 instead of MAX8998 Lukasz Majewski
2012-03-28 10:19 ` Minkyu Kang
2012-03-28 10:26 ` [U-Boot] [PATCH 1/3] misc:pmic: Support for voltage to register value conversion function Stefano Babic
2012-03-28 11:26 ` Lukasz Majewski
2012-03-28 11:41 ` Stefano Babic
[not found] ` <20120328143820.44ca652c@lmajewski.digital.local>
2012-03-28 12:50 ` Stefano Babic [this message]
2012-03-28 13:13 ` Lukasz Majewski
2012-03-28 14:43 ` Stefano Babic
2012-03-29 7:39 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F73091B.4000708@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.