From: "Andreas Färber" <afaerber@suse.de>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification
Date: Wed, 28 Mar 2012 15:49:23 +0200 [thread overview]
Message-ID: <4F7316E3.6020807@suse.de> (raw)
In-Reply-To: <CAMo8BfKCgiaDf04w4FAfBxS-mdMVGhrWrD8U6EAqb1c31p--iQ@mail.gmail.com>
Am 28.03.2012 15:46, schrieb Max Filippov:
>>> +static void arm_cpu_reset(CPUState *c)
>>> +{
>>> + ARMCPU *cpu = ARM_CPU(c);
>>> + ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu);
>>> +
>>> + class->parent_reset(c);
>>
>> I thought we were avoiding 'class' in favour of 'klass'?
>
> I have suggested it once and I can only say it again,
> please, call it 'cpu_class'. It is the least surprising name.
No, cpu_class is being used for a different class, CPUClass, when
twiddling with reset handlers of the parent class, for instance.
We could call it arm_cpu_class, but is that any better?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-03-28 13:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 17:28 [Qemu-devel] [PATCH v6 0/2] QOM'ify ARM CPU Andreas Färber
2012-03-26 17:28 ` [Qemu-devel] [PATCH v6 1/2] target-arm: Drop cpu_arm_close() Andreas Färber
2012-03-26 17:28 ` [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification Andreas Färber
2012-03-28 13:40 ` Peter Maydell
2012-03-28 13:46 ` Max Filippov
2012-03-28 13:49 ` Andreas Färber [this message]
2012-03-28 14:00 ` Max Filippov
2012-03-28 14:05 ` Andreas Färber
2012-03-28 13:46 ` Andreas Färber
2012-03-28 14:31 ` Peter Maydell
2012-03-28 14:22 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7316E3.6020807@suse.de \
--to=afaerber@suse.de \
--cc=jcmvbkbc@gmail.com \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.