From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Johannes Berg <johannes@sipsolutions.net>,
John Linville <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3.4] mac80211: fix association beacon wait timeout
Date: Wed, 28 Mar 2012 21:49:17 +0200 [thread overview]
Message-ID: <4F736B3D.5050408@hartkopp.net> (raw)
In-Reply-To: <1332961366.3479.41.camel@jlt3.sipsolutions.net>
On 28.03.2012 21:02, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> The TU_TO_EXP_TIME() macro already includes the
> "jiffies +" piece of the calculation, so don't
> add jiffies again.
>
> Reported-by: Oliver Hartkopp <socketcan@hartkopp.net>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>
three times :-)
Thanks Johannes!
> ---
> net/mac80211/mlme.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/net/mac80211/mlme.c 2012-03-28 20:55:35.000000000 +0200
> +++ b/net/mac80211/mlme.c 2012-03-28 20:56:14.000000000 +0200
> @@ -3387,8 +3387,7 @@ int ieee80211_mgd_assoc(struct ieee80211
> */
> printk(KERN_DEBUG "%s: waiting for beacon from %pM\n",
> sdata->name, ifmgd->bssid);
> - assoc_data->timeout = jiffies +
> - TU_TO_EXP_TIME(req->bss->beacon_interval);
> + assoc_data->timeout = TU_TO_EXP_TIME(req->bss->beacon_interval);
> } else {
> assoc_data->have_beacon = true;
> assoc_data->sent_assoc = false;
>
>
prev parent reply other threads:[~2012-03-28 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 19:02 [PATCH 3.4] mac80211: fix association beacon wait timeout Johannes Berg
2012-03-28 19:49 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F736B3D.5050408@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.