From: Eliot Blennerhassett <eblennerhassett@audioscience.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] ALSA: asihpi - fix return type of hpios_locked_mem_alloc()
Date: Wed, 28 Mar 2012 21:43:20 +0000 [thread overview]
Message-ID: <4F7385F8.4050004@audioscience.com> (raw)
In-Reply-To: <20120328065702.GA9113@elgon.mountain>
On 29/03/12 03:38, Takashi Iwai wrote:
> At Wed, 28 Mar 2012 09:57:02 +0300,
> Dan Carpenter wrote:
>>
>> This function returns zero or -ENOMEM, but because it's type is u16, the
>> -ENOMEM gets changed to 65524. None of the callers care, but lets fix
>> it anyway as a cleanup.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Applied it now. Thanks.
Hmm. I guess it is too late to NAK this change?
I'd prefer changing the return value to HPI_ERROR_MEMORY_ALLOC and
leaving the function signature alone.
Any chance to make this change?
--
Eliot
next prev parent reply other threads:[~2012-03-28 21:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 6:57 [patch] ALSA: asihpi - fix return type of hpios_locked_mem_alloc() Dan Carpenter
2012-03-28 6:57 ` Dan Carpenter
2012-03-28 14:38 ` Takashi Iwai
2012-03-28 14:38 ` Takashi Iwai
2012-03-28 21:43 ` Eliot Blennerhassett [this message]
2012-03-29 5:33 ` Takashi Iwai
2012-03-29 5:33 ` Takashi Iwai
2012-03-29 5:56 ` Dan Carpenter
2012-03-29 5:56 ` Dan Carpenter
2012-03-29 20:52 ` [PATCH] ALSA: asihpi - fix return value " linux
2012-03-29 20:52 ` linux
2012-03-30 14:25 ` Takashi Iwai
2012-03-30 14:25 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7385F8.4050004@audioscience.com \
--to=eblennerhassett@audioscience.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.