From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDEKQ-0003Sx-E5 for qemu-devel@nongnu.org; Thu, 29 Mar 2012 08:19:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDEKO-0000nu-L5 for qemu-devel@nongnu.org; Thu, 29 Mar 2012 08:19:45 -0400 Received: from goliath.siemens.de ([192.35.17.28]:20851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDEKO-0000nd-BT for qemu-devel@nongnu.org; Thu, 29 Mar 2012 08:19:44 -0400 Message-ID: <4F74535A.30808@siemens.com> Date: Thu, 29 Mar 2012 14:19:38 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4F633153.9030004@siemens.com> <4F633D37.60806@us.ibm.com> <4F633D93.4050701@siemens.com> In-Reply-To: <4F633D93.4050701@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Kick io-thread on qemu_chr_accept_input List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Marek Vasut , qemu-devel , Paolo Bonzini On 2012-03-16 14:18, Jan Kiszka wrote: > On 2012-03-16 14:16, Anthony Liguori wrote: >> On 03/16/2012 07:25 AM, Jan Kiszka wrote: >>> Once a chr frontend is able to receive input again, we need to inform >>> the io-thread about this fact. Otherwise, main_loop_wait may continue to >>> select without the related backend file descriptor in its set. This can >>> cause high input latencies if only low-rate events arrive otherwise. >>> >>> Signed-off-by: Jan Kiszka >> >> I'm not nacking this patch, but please note that this is a band-aid as not all >> char devices actually use qemu_chr_accept_input(). > > Then they have to be fixed. :) Could you apply the patch in the meantime? It is not band-aid, but a required base to fix such issues. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux