Re: [meta-oe 1/2] python-twisted: update to latest upstream version

[Gary Thomas <gary@mlbassoc.com>]

On 2012-03-29 05:54, Andreas Oberritter wrote:
> On 29.03.2012 13:47, Gary Thomas wrote:
>> On 2012-03-29 05:38, Andreas Oberritter wrote:
>>> Hi Gary,
>>>
>>> I was going to submit a similar patch. See my comments inline.
>>
>> Feel free to submit yours - I have no investment in my version, it was
>> purely
>> an update of the one in the current repo with a couple of tweaks.
>
> I held it back, because I haven't decided yet what to do with the
> unpackaged files:
>
> WARNING: For recipe python-twisted, the following files/directories were installed but not shipped in any package:
> WARNING:   /usr/lib/python2.7/site-packages/Twisted-12.0.0-py2.7.egg-info
> WARNING:   /usr/lib/python2.7/site-packages/Twisted-12.0.0-py2.7.egg-info/top_level.txt
> WARNING:   /usr/lib/python2.7/site-packages/Twisted-12.0.0-py2.7.egg-info/requires.txt
> WARNING:   /usr/lib/python2.7/site-packages/Twisted-12.0.0-py2.7.egg-info/SOURCES.txt
> WARNING:   /usr/lib/python2.7/site-packages/Twisted-12.0.0-py2.7.egg-info/PKG-INFO
> WARNING:   /usr/lib/python2.7/site-packages/Twisted-12.0.0-py2.7.egg-info/dependency_links.txt
> WARNING:   /usr/lib/python2.7/site-packages/Twisted-12.0.0-py2.7.egg-info/not-zip-safe
> WARNING:   /usr/lib/python2.7/site-packages/twisted/topfiles
> WARNING:   /usr/lib/python2.7/site-packages/twisted/topfiles/README
> WARNING:   /usr/lib/python2.7/site-packages/twisted/topfiles/NEWS
> WARNING:   /usr/lib/python2.7/site-packages/twisted/topfiles/CREDITS
> WARNING:   /usr/lib/python2.7/site-packages/twisted/topfiles/ChangeLog.Old
> WARNING:   /usr/lib/python2.7/site-packages/twisted/python/_initgroups.c
> WARNING:   /usr/lib/python2.7/site-packages/twisted/python/twisted-completion.zsh
> WARNING:   /usr/lib/python2.7/site-packages/twisted/python/_epoll.c

I see these as well - I'm not sure if it's useful to package them as they
are just [human readable] information...  Not terribly important on _my_
embedded platform :-)

>
> I also wonder why _initgroups.c and _epoll.c don't get deleted by the command
> in do_install_append(). Did you observe the same behaviour?

Looks like at least a typo and something strange with the quoting?  I just tried this:

diff --git a/packages/python/python-twisted_12.0.0.bb b/packages/python/python-twisted_12.0.0.bb
index a642656..536296f 100644
--- a/packages/python/python-twisted_12.0.0.bb
+++ b/packages/python/python-twisted_12.0.0.bb
@@ -18,7 +18,8 @@ inherit setuptools

  do_install_append() {
      # remove some useless files before packaging
-    find ${D} -name "*.bat" -o -name "*.c" -o -name "*.h" -exec rm {} \;
+    find ${D} -name "*.bat" -o -name "*.c" -o -name "*.h" -print -exec rm \{} \;
+    find ${D} -name "*.bat" -o -name "*.c" -o -name "*.h" | xargs -t rm
  }

The first command (which I think needs the \{} instead of {} - at least that's how
I've always seen it used) only finds a single .h file.  The second version works
properly (and is "cheaper" since all the files are deleted at once)

>
>> BTW, I couldn't figure out how to get 'git' to recognize this as a rename
>> with changes when I commited the change.  Any hints?
>
> It depends on the percentage of changed lines. See the --find-renames option
> of git-diff(1).

Thanks

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------