All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Jia Liu <proljc@gmail.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH V3 11/12] Handle MIPS DSP instructions in target-mips/translate.c
Date: Thu, 29 Mar 2012 09:20:37 -0400	[thread overview]
Message-ID: <4F7461A5.50300@twiddle.net> (raw)
In-Reply-To: <CAJBMM-tb6TU=uEwPKaUZpB-xg9wAWO0q+-x9xy0vu0mWmvKEhg@mail.gmail.com>

On 03/27/2012 09:36 PM, Jia Liu wrote:
>> > This patch should have been split as well, adding translations of the insns
>> > at the same time you add the helpers.  That said, the actual code looks ok.
>> >
> helpers can be grouped by MIPS DSP manual, BUT translations have to
> grouped by opcode.
> There is some difference between them, I'll try to do this.
> 

One possibility is to add the bare skeleton of the decoding by opcode first,
leaving out the actual case statements.  Then add the

  case OPCODE:
    gen_helper();
    break;

in the patch adding the helpers.


r~

  reply	other threads:[~2012-03-29 13:20 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27  9:24 [Qemu-devel] [PATCH V3 00/12] Qemu MIPS ASE DSP Support Jia Liu
2012-03-27  9:24 ` [Qemu-devel] [PATCH V3 01/12] add MIPS DSP internal functions Jia Liu
2012-03-27 15:33   ` Richard Henderson
2012-03-28  2:03     ` Jia Liu
2012-03-29 11:16       ` Richard Henderson
2012-03-27  9:24 ` [Qemu-devel] [PATCH V3 02/12] Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number Jia Liu
2012-03-27 15:34   ` Richard Henderson
2012-03-27  9:24 ` [Qemu-devel] [PATCH V3 03/12] Add MIPS DSP Branch instruction Support Jia Liu
2012-03-27 15:46   ` Richard Henderson
2012-03-28  1:27     ` Jia Liu
2012-03-27  9:24 ` [Qemu-devel] [PATCH V3 04/12] Add MIPS DSP Load instructions Support Jia Liu
2012-03-27 15:49   ` Richard Henderson
2012-03-28  1:46     ` Jia Liu
2012-03-27  9:24 ` [Qemu-devel] [PATCH V3 05/12] Add helper functions for MIPS DSP Arithmetic instructions Jia Liu
2012-03-27 16:03   ` Richard Henderson
2012-03-28  1:45     ` Jia Liu
2012-03-27  9:24 ` [Qemu-devel] [PATCH V3 06/12] Add helper functions for MIPS DSP GPR-Based Shift instructions Jia Liu
2012-03-27 16:11   ` Richard Henderson
2012-03-28  1:43     ` Jia Liu
2012-03-29 13:09       ` Richard Henderson
2012-03-27  9:24 ` [Qemu-devel] [PATCH V3 07/12] Add helper functions for MIPS DSP Multiply instructions Jia Liu
2012-03-27  9:24 ` [Qemu-devel] [PATCH V3 08/12] Add helper functions for MIPS DSP Bit/Manipulation instructions Jia Liu
2012-03-27 16:23   ` Richard Henderson
2012-03-28  1:47     ` Jia Liu
2012-03-27  9:24 ` [Qemu-devel] [PATCH V3 09/12] Add helper functions for MIPS DSP Compare-Pick instructions Jia Liu
2012-03-27 17:42   ` Richard Henderson
2012-03-28  1:52     ` Jia Liu
2012-03-27  9:24 ` [Qemu-devel] [PATCH V3 10/12] Add helper functions for MIPS DSP Accumulator and DSPControl Access instrutions helpers Jia Liu
2012-03-27  9:24 ` [Qemu-devel] [PATCH V3 11/12] Handle MIPS DSP instructions in target-mips/translate.c Jia Liu
2012-03-27 17:48   ` Richard Henderson
2012-03-28  1:36     ` Jia Liu
2012-03-29 13:20       ` Richard Henderson [this message]
2012-03-27  9:24 ` [Qemu-devel] [PATCH V3 12/12] add MIPS DSP testcases Jia Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7461A5.50300@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aurelien@aurel32.net \
    --cc=proljc@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.