From: Stephen Warren <swarren@wwwdotorg.org>
To: Shridhar Rasal <srasal@nvidia.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Stephen Warren <swarren@nvidia.com>,
"rydberg@euromail.se" <rydberg@euromail.se>,
Rakesh Iyer <riyer@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 1/1] input: keyboard: Set configuration registers
Date: Thu, 29 Mar 2012 09:49:48 -0600 [thread overview]
Message-ID: <4F74849C.4090907@wwwdotorg.org> (raw)
In-Reply-To: <4F71DB3E.4090606@wwwdotorg.org>
On 03/27/2012 09:22 AM, Stephen Warren wrote:
> On 03/26/2012 11:17 PM, Shridhar Rasal wrote:
>> On 02/01/2012 01:17 AM, Dmitry Torokhov wrote:
>>> On Tue, Jan 31, 2012 at 11:29:35AM -0800, Stephen Warren wrote:
...
>>>> I'd rather PIN_CFG_IGNORE was the first enum, so it gets value 0, or
>>>> this probably won't solve the original issue?
>>>
>>> The benefit of current definition is that it is compatible with old
>>> ones using bool...
>>>
>>> Thanks.
>>
>> Sorry for delay in response.
>> I am OK with new definition. Agree, makes compatible with old definitions.
>> Thanks!
>
> Which new definition; the one in Dmitry's patch, or what I proposed
> above? Note that from what I recall, Dmitry's patch doesn't solve the
> problem.
Nevermind, I see this patch has been modified to address my concerns,
and already applied.
prev parent reply other threads:[~2012-03-29 15:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 7:29 [PATCH 1/1] input: keyboard: Set configuration registers Shridhar Rasal
2011-12-09 20:10 ` Stephen Warren
2011-12-09 21:25 ` Dmitry Torokhov
2011-12-09 23:17 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF17518605E5-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-12-30 3:25 ` Dmitry Torokhov
2011-12-30 3:25 ` Dmitry Torokhov
2012-01-31 19:09 ` Dmitry Torokhov
2012-01-31 19:29 ` Stephen Warren
2012-01-31 19:47 ` Dmitry Torokhov
2012-01-31 19:51 ` Stephen Warren
[not found] ` <20120131194735.GA22872-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2012-03-27 5:17 ` Shridhar Rasal
2012-03-27 5:17 ` Shridhar Rasal
[not found] ` <4F714D5C.1050400-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-03-27 15:22 ` Stephen Warren
2012-03-27 15:22 ` Stephen Warren
2012-03-29 15:49 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F74849C.4090907@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=riyer@nvidia.com \
--cc=rydberg@euromail.se \
--cc=srasal@nvidia.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.