From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 05/13] KVM: MMU: reset shadow_mmio_mask Date: Thu, 29 Mar 2012 18:24:59 +0200 Message-ID: <4F748CDB.8020104@redhat.com> References: <4F742951.7080003@linux.vnet.ibm.com> <4F742A06.8090604@linux.vnet.ibm.com> <4F745F28.2040105@redhat.com> <4F747F91.20005@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , LKML , KVM To: Xiao Guangrong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:22820 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757939Ab2C2QZD (ORCPT ); Thu, 29 Mar 2012 12:25:03 -0400 In-Reply-To: <4F747F91.20005@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/29/2012 05:28 PM, Avi Kivity wrote: > On 03/29/2012 03:10 PM, Avi Kivity wrote: > > On 03/29/2012 11:23 AM, Xiao Guangrong wrote: > > > Do not use the last byte (bit 56 ~ bit 63) in shadow_mmio_mask, the late > > > patch will store vcpu id in the last byte > > > > Bit 63 is PT64_NX_MASK. > > Oh, you did say that with softmmu we're limited to 127 cpus. But what > if spte.nx is changed while we update the identity? Ok, saw that too. But I think test_and_set_bit() is better here, to reduce the complexity (note we need cmpxchg64b on 32-bit instead). -- error compiling committee.c: too many arguments to function