From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Subject: Re: [PATCH 03/13] KVM: MMU: split FNAME(prefetch_invalid_gpte)
Date: Fri, 30 Mar 2012 11:51:12 +0800
Message-ID: <4F752DB0.6060309@linux.vnet.ibm.com>
References: <4F742951.7080003@linux.vnet.ibm.com> <4F7429C7.9030307@linux.vnet.ibm.com> <4F745CFE.4070703@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e23smtp03.au.ibm.com ([202.81.31.145]:47045 "EHLO
	e23smtp03.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759808Ab2C3DwH (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 29 Mar 2012 23:52:07 -0400
Received: from /spool/local
	by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <kvm@vger.kernel.org> from <xiaoguangrong@linux.vnet.ibm.com>;
	Fri, 30 Mar 2012 03:43:21 +1000
In-Reply-To: <4F745CFE.4070703@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 03/29/2012 09:00 PM, Avi Kivity wrote:

> On 03/29/2012 11:22 AM, Xiao Guangrong wrote:
>> Split FNAME(prefetch_invalid_gpte) to check gpte independently which will
>> be used in the later patch
>>
>>
>> -static bool FNAME(prefetch_invalid_gpte)(struct kvm_vcpu *vcpu,
>> -				    struct kvm_mmu_page *sp, u64 *spte,
>> -				    pt_element_t gpte)
>> +static bool FNAME(invalid_gpte)(struct kvm_vcpu *vcpu, pt_element_t gpte)
>>  {
>>  	if (is_rsvd_bits_set(&vcpu->arch.mmu, gpte, PT_PAGE_TABLE_LEVEL))
>> -		goto no_present;
>> +		return true;
>>
>>  	if (!is_present_gpte(gpte))
>> -		goto no_present;
>> +		return true;
>>
>>  	if (!(gpte & PT_ACCESSED_MASK))
>> -		goto no_present;
>> +		return true;
>>
>>  	return false;
> 
> A comment (or a name change) is needed to indicate that we're not
> checking for an invalid gpte, just invalid for caching in an spte.


Yes, i will change the name to FNAME(is_cacheable_gpte) and and some
comments.