From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Subject: Re: [PATCH 04/13] KVM: MMU: introduce FNAME(get_sp_gpa)
Date: Fri, 30 Mar 2012 13:01:47 +0800
Message-ID: <4F753E3B.4040308@linux.vnet.ibm.com>
References: <4F742951.7080003@linux.vnet.ibm.com> <4F7429E7.3010801@linux.vnet.ibm.com> <4F745E7D.5080102@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e23smtp01.au.ibm.com ([202.81.31.143]:60462 "EHLO
	e23smtp01.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751393Ab2C3FB4 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 30 Mar 2012 01:01:56 -0400
Received: from /spool/local
	by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <kvm@vger.kernel.org> from <xiaoguangrong@linux.vnet.ibm.com>;
	Fri, 30 Mar 2012 04:54:40 +1000
In-Reply-To: <4F745E7D.5080102@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 03/29/2012 09:07 PM, Avi Kivity wrote:

> On 03/29/2012 11:22 AM, Xiao Guangrong wrote:
>> It can calculate the base gpa of the specified shadow page on any level,
>> let it instead of FNAME(get_level1_sp_gpa)
>>
>>
>> +static gpa_t FNAME(get_sp_gpa)(struct kvm_mmu_page *sp)
>> +{
> 
> Maybe worth adding a pte index and calling it get_spte_gpa(), depends on
> the next patches I guess.
> 


Yes.

But FNAME(get_sp_gpa) is still needed by FNAME(sync_page) path which sync
all sptes. I will introduce get_spte_gpa() as you mentioned which will be
used in invlpg path and in the later patch.


>> +	int offset, shift;
>> +
>> +	shift = PAGE_SHIFT - (PT_LEVEL_BITS - PT64_LEVEL_BITS) * sp->role.level;
>> +	offset = sp->role.quadrant << shift;
> 
> if you add '& ~PAGE_MASK' the compiler may be smart enough to drop the
> whole thing for 64-bit ptes.
> 


Sorry. how to do that?

But if you want to remove the unnecessary workload, i will change it
like this:

static gpa_t FNAME(get_sp_gpa)(struct kvm_mmu_page *sp)
{
	int offset = 0;

#if PTTYPE == 32
	int shift;

	shift = PAGE_SHIFT - (PT_LEVEL_BITS - PT64_LEVEL_BITS) * sp->role.level;
	offset = sp->role.quadrant << shift;
#endif
	return gfn_to_gpa(sp->gfn) + offset;
}