From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC] qxl: don't panic on phys2virt
Date: Fri, 30 Mar 2012 10:09:42 +0200 [thread overview]
Message-ID: <4F756A46.50102@redhat.com> (raw)
In-Reply-To: <1333054606-19847-1-git-send-email-alevy@redhat.com>
On 03/29/12 22:56, Alon Levy wrote:
> Issues a qxl_guest_bug from qxl_phys2virt. Everywhere else will fail.
Nice start (there are more guest-triggerable asserts to be fixed this way).
> qxl_phys2virt requires an additional argument because all it's possible
> return values are legit (well, I could use the fact it returns a pointer
> so it should be word aligned but I don't want to go there, this is
> totally internal).
Really? What is bad with returning and checking for NULL? Guest
memslots are backed by guest ram and should never ever resolve to a NULL
pointer in qemu's process address space.
cheers,
Gerd
next prev parent reply other threads:[~2012-03-30 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 20:56 [Qemu-devel] [RFC] qxl: don't panic on phys2virt Alon Levy
2012-03-30 8:09 ` Gerd Hoffmann [this message]
2012-03-30 19:27 ` Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F756A46.50102@redhat.com \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.