From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>, Benoit Cousson <b-cousson@ti.com>,
linux-omap <linux-omap@vger.kernel.org>,
Kevin Hilman <khilman@ti.com>
Subject: Re: OMAP4 errata i740
Date: Fri, 30 Mar 2012 14:01:34 +0530 [thread overview]
Message-ID: <4F756F66.6020103@ti.com> (raw)
In-Reply-To: <1333095982.1932.21.camel@deskari>
+ Kevin
On Friday 30 March 2012 01:56 PM, Tomi Valkeinen wrote:
> On Fri, 2012-03-30 at 13:51 +0530, Shilimkar, Santosh wrote:
>> On Fri, Mar 30, 2012 at 1:37 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>
>>> All OMAP4 versions seem to be affected. I couldn't find a mention about
>>> this in the mainline kernel. Any ideas how and where this should be
>>> fixed?
>>>
>> It's not patched for mainline. Generally clock-domain code
>> is abstracted from drivers but considering the errata and affected
>> modules, I guees it should be handled by DSS driver
>> since that is where the state of DSS or ISS will be known. Note
>> ISS will be automatically taken care since it will always use disaplay.
>>
>> In internal tree's this was handled as part of DSS early suspend/resume
>
> That version doesn't work as it uses functions that are not exported to
> drivers.
>
> I don't know much about the clock domain code, but I hope there's a way
> to handle it there. Otherwise I guess I need to add a new set of
> platform callback functions, so that the dss driver can call
> arch/arm/mach-omap2 code to enable and disable the work-around. I
> dislike that because I'm currently trying to remove those kinds of hacks
> to make dss work better with DT =).
>
I agree. In fact I faced similar issue when I briefly tried moving
OMAP cpuidle code to drivers/idle/*.
That time me and Kevin concluded that till we move the powerdomain,
clockdomain code to drivers/* and export it, the cpuidle movement
needs to be deferred.
Regards
Santosh
next prev parent reply other threads:[~2012-03-30 8:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 8:07 OMAP4 errata i740 Tomi Valkeinen
2012-03-30 8:21 ` Shilimkar, Santosh
2012-03-30 8:26 ` Tomi Valkeinen
2012-03-30 8:31 ` Santosh Shilimkar [this message]
2012-03-30 8:34 ` Archit Taneja
2012-03-30 8:44 ` Santosh Shilimkar
2012-03-30 10:23 ` Cousson, Benoit
2012-03-30 10:29 ` Santosh Shilimkar
2012-03-30 10:56 ` Archit Taneja
2012-03-30 11:04 ` Shilimkar, Santosh
2012-03-30 11:17 ` Archit Taneja
2012-03-30 11:20 ` Shilimkar, Santosh
2012-03-30 11:59 ` Tomi Valkeinen
2012-03-30 12:02 ` Cousson, Benoit
2012-03-30 12:06 ` Tomi Valkeinen
2012-03-30 12:00 ` Cousson, Benoit
2012-03-30 12:24 ` Santosh Shilimkar
2012-03-30 10:08 ` Cousson, Benoit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F756F66.6020103@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=b-cousson@ti.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.