From: Richard Henderson <rth@twiddle.net>
To: Jia Liu <proljc@gmail.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH V4 00/11] Qemu MIPS ASE DSP Support
Date: Fri, 30 Mar 2012 08:56:10 -0400 [thread overview]
Message-ID: <4F75AD6A.2050006@twiddle.net> (raw)
In-Reply-To: <4F759C0E.3000606@twiddle.net>
On 03/30/2012 07:42 AM, Richard Henderson wrote:
> All of your helpers, whereever they receive or return a register value, need to use
> type target_ulong and the DEF_HELPER lines need to use "tl". All of the mips32
> helpers you've written so far that return values need to make sure to sign-extend
> their results from 32-bits.
Hmm, actually I wonder if that's the best advice.
It looks like your translated code isn't going to work well with r0.
I suspect it would be better to add a gen_load_gpr32 function for the
translator that (1) sets 0 for r0, (2a) copies the register for mips32,
and (2b) truncates the register for mips64. That way 32-bit hosts do
not need to use 64-bit arithmetic when unnecessary. You'd need a
gen_store_gpr32 function as well, which for mips64 sign-extends the value.
r~
next prev parent reply other threads:[~2012-03-30 12:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 3:17 [Qemu-devel] [PATCH V4 00/11] Qemu MIPS ASE DSP Support Jia Liu
2012-03-30 3:17 ` [Qemu-devel] [PATCH V4 01/11] Add MIPS DSP internal functions Jia Liu
2012-03-30 3:17 ` [Qemu-devel] [PATCH V4 02/11] Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number Jia Liu
2012-03-30 3:17 ` [Qemu-devel] [PATCH V4 03/11] Add MIPS DSP Branch instruction Support Jia Liu
2012-03-30 3:17 ` [Qemu-devel] [PATCH V4 04/11] Add MIPS DSP Load instructions Support Jia Liu
2012-03-30 10:33 ` Richard Henderson
2012-03-30 3:17 ` [Qemu-devel] [PATCH V4 05/11] Add MIPS DSP Arithmetic " Jia Liu
2012-03-30 3:17 ` [Qemu-devel] [PATCH V4 06/11] Add MIPS DSP GPR-Based Shift " Jia Liu
2012-03-30 3:17 ` [Qemu-devel] [PATCH V4 07/11] Add MIPS DSP Multiply " Jia Liu
2012-03-30 3:17 ` [Qemu-devel] [PATCH V4 08/11] Add MIPS DSP Bit/Manipulation " Jia Liu
2012-03-30 11:05 ` Richard Henderson
2012-03-30 12:19 ` Jia Liu
2012-03-30 3:17 ` [Qemu-devel] [PATCH V4 09/11] Add MIPS DSP Compare-Pick " Jia Liu
2012-03-30 3:17 ` [Qemu-devel] [PATCH V4 10/11] Add MIPS DSP Accumulator and DSPControl Access " Jia Liu
2012-03-30 3:17 ` [Qemu-devel] [PATCH V4 11/11] Add MIPS DSP Testcases Jia Liu
2012-03-30 11:42 ` [Qemu-devel] [PATCH V4 00/11] Qemu MIPS ASE DSP Support Richard Henderson
2012-03-30 12:18 ` Jia Liu
2012-03-30 12:56 ` Richard Henderson [this message]
2012-04-04 14:52 ` Jia Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F75AD6A.2050006@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.