Re: [PATCH 4/7] Revert "lib/bb/ui/crumbs/hig: fix layers_changed test"

[Joshua Lock <josh@linux.intel.com>]

On 30/03/12 05:01, Dongxiao Xu wrote:
> We do not sort the layer list, therefore when response_cb, the ordering
> is also not needed.
>
> This reverts commit 71c1de347eef07a2059fc4544dc3cae090181f44.

This only makes sense if 3/7 is merged, correct?

Cheers,
Joshua

> ---
>   lib/bb/ui/crumbs/hig.py |    5 +----
>   1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/lib/bb/ui/crumbs/hig.py b/lib/bb/ui/crumbs/hig.py
> index 9a38bc0..0ac4496 100644
> --- a/lib/bb/ui/crumbs/hig.py
> +++ b/lib/bb/ui/crumbs/hig.py
> @@ -958,10 +958,7 @@ class LayerSelectionDialog (CrumbsDialog):
>               layers.append(model.get_value(it, 0))
>               it = model.iter_next(it)
>
> -        orig_layers = sorted(self.layers)
> -        layers.sort()
> -
> -        self.layers_changed = (orig_layers != layers)
> +        self.layers_changed = (self.layers != layers)
>           self.layers = layers
>
>       """

-- 
Joshua '贾詡' Lock
         Yocto Project "Johannes factotum"
         Intel Open Source Technology Centre