Re: [GIT] HID #2

[Joseph Salisbury <joseph.salisbury@canonical.com>]

On 03/27/2012 01:53 PM, Jiri Kosina wrote:
> On Tue, 27 Mar 2012, Joseph Salisbury wrote:
> 
>>> this is an updated pull request (I sent you the original one on Thu, 5 Jan 
>>> 2012 22:39:01 +0100 (CET)); as you haven't pulled the previous one yet, I 
>>> have update the for-linus branch with the patches from Jeremy that fix 
>>> battery reporting for apple devices, as due to my mistake, outdated 
>>> version of the patchset has been included in the branch originally.
>>>
>>> Other than that, nothing new has been added on top of previous request.
>>>
>>> Thanks in advance.
>>>
>>>
>>> The following changes are available in the git repository at:
>>>
>>>   git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus
>>>
>>> Aaron Tian (1):
>>>       HID: multitouch: support PixArt optical touch screen
>>>
>>> Benjamin Tissoires (10):
>>>       HID: multitouch: create sysfs attribute to control quirks from user-space
>>>       HID: multitouch: cleanup eGalax quirks
>>>       HID: multitouch: remove .maxcontacts field for eGalax
>>>       HID: multitouch: cleanup with eGalax PID definitions
>>>       HID: multitouch: add support for the MSI Windpad 110W
>>>       HID: multitouch: correct eGalax a001 protocol
>>>       HID: multitouch: merge quanta driver into hid-multitouch
>>>       HID: hid-multitouch: add support for new Hanvon panels
>>>       HID: multitouch: add support of Atmel multitouch panels
>>>       HID: multitouch: add support for 3M 32"
>>>
>>> Chase Douglas (1):
>>>       HID: bump maximum global item tag report size to 96 bytes
>>>
>>> Chris Bagwell (1):
>>>       HID: hid-multitouch - add another eGalax id
>>>
>>> Dan Delaney (1):
>>>       HID/usbled: add support for Dream Cheeky DL100B Mailbox Friends Alert
>>>
>>> Daniel Kurtz (3):
>>>       HID: usbhid: remove LED_ON
>>>       HID: usbhid: hid-core: submit queued urbs before suspend
>>>       HID: usbhid: defer LED setting to a workqueue
>>>
>>> Daniel Nicoletti (1):
>>>       hid-input: add support for HID devices reporting Battery Strength
>>>
>>> David Herrmann (18):
>>>       HID: wiimote: Rename driver to allow multiple source files
>>>       HID: wiimote: Move common symbols into header
>>>       HID: wiimote: Add read-mem helpers
>>>       HID: wiimote: Add extension support stub
>>>       HID: wiimote: Add extension initializer stubs
>>>       HID: wiimote: Add extension initializers
>>>       HID: wiimote: Add extension sysfs attribute
>>>       HID: wiimote: Register input devices for extensions
>>>       HID: wiimote: Add extension handler stubs
>>>       HID: wiimote: Parse motion+ data
>>>       HID: wiimote: Parse nunchuck data
>>>       HID: wiimote: Parse classic controller data
>>>       HID: wiimote: Add debugfs support stubs
>>>       HID: wiimote: Allow direct eeprom access
>>>       HID: wiimote: Allow direct DRM debug access
>>>       HID: wiimote: Remove module version number
>>>       HID: wiimote: Enable NO_INIT_REPORTS quirk
>>>       HID: wiimote: Select INPUT_FF_MEMLESS
>>>
>>> Ignaz Forster (1):
>>>       HID: Enable HID_QUIRK_MULTI_INPUT for Trio Linker Plus II
>>>
>>> Jeremy Fitzhardinge (10):
>>>       HID: debugfs: decode Generic Device Controls Usage Page
>>>       HID: hid-input: add support for HID devices reporting Battery Strength
>>>       HID: hid-input: fix compile for !HID_BATTERY_STRENGTH
>>>       hid-input/battery: remove apparently redundant kmalloc
>>>       hid-input/battery: add quirks for battery
>>>       hid-input/battery: deal with both FEATURE and INPUT report batteries
>>>       hid-input/battery: make the battery setup common for INPUTs and FEATUREs
>>>       hid-input/battery: power-supply type really *is* a battery
>>>       hid-input/battery: remove battery_val
>>>       hid-input/battery: add FEATURE quirk
>>>
>>> Jiri Kosina (9):
>>>       HID: ignore absolute values which don't fit between logical min and max
>>>       HID: be more strict when ignoring out-of-range fields
>>>       HID: hyperv: fixup Kconfig / Makefile entries
>>>       HID: multitouch: make struct mt_classess static
>>>       HID: picolcd: make fb_pending_lock and picolcd_fb_cleanup static
>>>       HID: make parser more verbose about parsing errors by default
>>>       HID: introduce proper dependency of HID_BATTERY on POWER_SUPPLY
>>>       HID: Kconfig: fix syntax
>>>       HID: emsff: use symbolic name instead of hardcoded PID constant
>>>
>>> K. Y. Srinivasan (3):
>>>       HID: Move the hid-hyperv driver out of staging
>>>       Staging: hv: mousevsc: Remove the mouse driver from the staging tree
>>>       HID: hv_mouse: Properly add the hid device
>>>
>>> Marek Vasut (1):
>>>       HID: multitouch: Add egalax ID for Acer Iconia W500
>>>
>>> Masatoshi Hoshikawa (1):
>>>       HID: hid-multitouch: add support 9 new Xiroku devices
>>>
>>> Przemo Firszt (2):
>>>       HID: wacom: Move parsing to a separate function
>>>       HID: wacom: Initial driver for Wacom Intuos4 Wireless (Bluetooth)
>>>
>>> Stefan Achatz (1):
>>>       HID: roccat: Add support for Isku keyboard
>>>
>>> Thomas Meyer (2):
>>>       HID: hid-lg4ff: Casting (void *) value returned by kmalloc is useless
>>>       HID: roccat: Use kmemdup rather than duplicating its implementation
>>>
>>> Willem Penninckx (2):
>>>       HID: usbkbd: synchronize LED URB submission
>>>       HID: usbkbd: kill LED URB on disconnect
>>>
>>>  .../ABI/testing/sysfs-driver-hid-multitouch        |    9 +
>>>  .../ABI/testing/sysfs-driver-hid-roccat-isku       |  135 ++++
>>>  Documentation/ABI/testing/sysfs-driver-hid-wiimote |   12 +
>>>  drivers/hid/Kconfig                                |   38 +-
>>>  drivers/hid/Makefile                               |   11 +-
>>>  drivers/hid/hid-core.c                             |   82 ++-
>>>  drivers/hid/hid-debug.c                            |    8 +
>>>  drivers/hid/hid-emsff.c                            |    2 +-
>>>  .../{staging/hv/hv_mouse.c => hid/hid-hyperv.c}    |  303 ++++----
>>>  drivers/hid/hid-ids.h                              |   43 +-
>>>  drivers/hid/hid-input.c                            |  228 ++++++-
>>>  drivers/hid/hid-lg4ff.c                            |    2 +-
>>>  drivers/hid/hid-multitouch.c                       |  213 +++++--
>>>  drivers/hid/hid-picolcd.c                          |    4 +-
>>>  drivers/hid/hid-quanta.c                           |  261 -------
>>>  drivers/hid/hid-roccat-common.c                    |    4 +-
>>>  drivers/hid/hid-roccat-isku.c                      |  487 +++++++++++++
>>>  drivers/hid/hid-roccat-isku.h                      |  147 ++++
>>>  drivers/hid/hid-roccat-kone.c                      |    4 +-
>>>  drivers/hid/hid-wacom.c                            |  179 ++++-
>>>  drivers/hid/{hid-wiimote.c => hid-wiimote-core.c}  |  246 +++----
>>>  drivers/hid/hid-wiimote-debug.c                    |  227 ++++++
>>>  drivers/hid/hid-wiimote-ext.c                      |  752 ++++++++++++++++++++
>>>  drivers/hid/hid-wiimote.h                          |  208 ++++++
>>>  drivers/hid/usbhid/hid-core.c                      |  241 ++++---
>>>  drivers/hid/usbhid/hid-quirks.c                    |    4 +
>>>  drivers/hid/usbhid/usbhid.h                        |    3 +-
>>>  drivers/hid/usbhid/usbkbd.c                        |   64 ++-
>>>  drivers/staging/hv/Kconfig                         |    6 -
>>>  drivers/staging/hv/Makefile                        |    1 -
>>>  drivers/usb/misc/usbled.c                          |    2 +
>>>  include/linux/hid.h                                |   21 +
>>>  32 files changed, 3151 insertions(+), 796 deletions(-)
>>>  create mode 100644 Documentation/ABI/testing/sysfs-driver-hid-multitouch
>>>  create mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-isku
>>>  rename drivers/{staging/hv/hv_mouse.c => hid/hid-hyperv.c} (75%)
>>>  delete mode 100644 drivers/hid/hid-quanta.c
>>>  create mode 100644 drivers/hid/hid-roccat-isku.c
>>>  create mode 100644 drivers/hid/hid-roccat-isku.h
>>>  rename drivers/hid/{hid-wiimote.c => hid-wiimote-core.c} (89%)
>>>  create mode 100644 drivers/hid/hid-wiimote-debug.c
>>>  create mode 100644 drivers/hid/hid-wiimote-ext.c
>>>  create mode 100644 drivers/hid/hid-wiimote.h
>>>
>>
>> I noticed stable@vger.kernel.org wasn't in the Cc list for this request.
>>  Jiri, will you be submitting a request to have this pulled into stable?
> 
> Definitely not the whole bunch, that's not how it works. Also, stable 
> doesn't pull from random git trees, it selectively cherry-picks commits 
> from Linus' tree.
> 
> If you feel like some commit should be added to -stable pile, you are free 
> to pick it up and submit to stable.
> 
> Thanks,
> 

Thanks for the feedback, Jiri.

I was interested in the following commit for linux-stable for support of
Apple bluetooth Keyboard(USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ANSI
0x0255):
652aa6a9ac4a5f8d3e1fa3f6466646519e83c01e hid-input/battery: add FEATURE
quirk

Jeremy, do you happen to know if this patch can be applied without the
needing the other 9 patches you provided in this commit?

Thanks,

Joe