Re: [PATCH] scripts: refactor remove structure forward declarations

[Stephen Boyd <sboyd@codeaurora.org>]

On 3/31/2012 6:59 PM, Jike Song wrote:
> Seems broke cscope build:
>
> $ make cscope
>   GEN     cscope
> sed: can't read cscope: No such file or directory
> make: *** [cscope] Error 2
>
> with V=1:
[snip]
> + cscope -b -f cscope.out
> + '[' -n ']'
> + LANG=C
> + sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct
> \1;.*\$\/;"\tx$/d' cscope
> sed: can't read cscope: No such file or directory
> make: *** [cscope] Error 2

Ah yes. Forgot the quotes.

---->8------

Subject: [PATCH] tags.sh: Add missing quotes

When $remove_structs is empty a test for empty string will turn
into test -n with no arguments meaning true. Add quotes so an
empty string is tested and so that make cscope works again.

Reported-by: Jike Song <albcamus@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 scripts/tags.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/tags.sh b/scripts/tags.sh
index 0d6004e..cf7b12f 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -254,6 +254,6 @@ case "$1" in
 esac

 # Remove structure forward declarations.
-if [ -n $remove_structs ]; then
+if [ -n "$remove_structs" ]; then
     LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' $1
 fi

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.