Re: [PATCH 0/3] PNP: Allow PNP resources to be disabled (interface)

[Witold Szczeponik <Witold.Szczeponik@gmx.net>]

On 27/03/12 22:57, Bjorn Helgaas wrote:

[...]

>
> If I understand this correctly, even with this patches, you still have
> to manually muck around with "/sys/bus/pnp/devices/*/resources" to get
> these ThinkPads to work?  If that's the case, there must be more PNP
> work we could do to make them Just Work.  And that's fine; I'm just
> trying to understand the current situation better.  Is there a
> bugzilla or other URL with more details?
>

Yes, this is true: even with this patch applied it is necessary to 
explicitly set the IRQ link to disabled.  Let me briefly explain it, 
using an excerpt from the 600E's DSDT (printer port):

    Name (PLPT, ResourceTemplate ()
    {
        StartDependentFnNoPri ()
        {
            IO (Decode16, 0x03BC, 0x03BC, 0x01, 0x04)
            IRQNoFlags () {7}
        }
        /* Some entries deleted */
        StartDependentFnNoPri ()
        {
            IO (Decode16, 0x03BC, 0x03BC, 0x01, 0x04)
            IRQNoFlags () {}
        }
        EndDependentFn ()
    })

As you can see, the IRQ line for the second option is empty/disabled. 
Also, both options share the same priority, there is no priority of 
the first option over the second option.

In order to be able to use the IRQ 7 for some other device, I need 
to be able to select the second option, which can be done with the 
patch series applied.

As for a bugzilla entry: I did not find any.  Frankly, I don't 
think there is one, for until recently, disabled resources were 
not handled at all (at least in the PNPACPI case).  Though, it is 
(remotely?) possible the handling of optional IRQ lines 
(IORESOURCE_IRQ_OPTIONAL) is obsolete these days (because the 
quirks that introduce that flag seem to fix a symptom that could 
have been fixed by commit 18fd470a48396c8795ba7256c5973e92ffa25cb3).


--- Witold