From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEcmv-0007cL-NP for qemu-devel@nongnu.org; Mon, 02 Apr 2012 04:39:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEcmp-0005vj-09 for qemu-devel@nongnu.org; Mon, 02 Apr 2012 04:38:57 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:27784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEcmo-0005vI-Qc for qemu-devel@nongnu.org; Mon, 02 Apr 2012 04:38:50 -0400 Received: from euspt2 ([210.118.77.14]) by mailout4.w1.samsung.com (Sun Java(tm) System Messaging Server 6.3-8.04 (built Jul 29 2009; 32bit)) with ESMTP id <0M1U005ZFG0PCA20@mailout4.w1.samsung.com> for qemu-devel@nongnu.org; Mon, 02 Apr 2012 09:38:49 +0100 (BST) Received: from [106.109.8.162] by spt2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0M1U00HI4G0IFD@spt2.w1.samsung.com> for qemu-devel@nongnu.org; Mon, 02 Apr 2012 09:38:43 +0100 (BST) Date: Mon, 02 Apr 2012 12:38:43 +0400 From: Igor Mitsyanko In-reply-to: <4F795CB7.9060404@suse.de> Message-id: <4F796593.1080306@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: QUOTED-PRINTABLE References: <4F795CB7.9060404@suse.de> Subject: Re: [Qemu-devel] [PATCH v1 1/2] SDHCI: inital version Reply-To: i.mitsyanko@samsung.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Kevin Wolf , Peter Maydell , vpalatin@chromium.org, qemu-devel@nongnu.org, "Peter A. G. Crosthwaite" , paul@codesourcery.com, duyl@xilinx.com, linnj@xilinx.com, edgar.iglesias@gmail.com, john.williams@petalogix.com, Dmitry Solodkiy On 04/02/2012 12:00 PM, Andreas F=C3=A4rber wrote: > Am 02.04.2012 09:20, schrieb Peter Maydell: >> On 2 April 2012 07:24, Peter A. G. Crosthwaite >> wrote: >>> device more for standard SD host controller interface (SDHCI). >>> >>> Signed-off-by: Peter A. G. Crosthwaite >> >> So how does this compare with Vincent Palatin's version? >> (http://patchwork.ozlabs.org/patch/106767/) I'm guessing from >> the copyright string that it's a modified version -- it would >> be nice to say what the differences are. > > ...and what the differences to Samsung's version are. > > We should probably also cc Kevin on the topic. > > Andreas It looks like this sdhc implements version 1 of standard SDHC=20 specification, while ours implements second version. Second version= =20 should be backwards compatible with first, I didn't want to submit it= =20 yet to see if vmstate issue will be resolved or not. And also the who= le=20 QEMU SD emulation scheme needs some refactoring which I've been busy= =20 with for a while now. The biggest issues are that currently we cannot= =20 hot-insert SD card into virtual board interface and we do not take an= y=20 advantage of QOM (which is hard until Paolo's and Andrea's patches la= nd=20 in master). The one advantage of our SDHCI implementation is that it provides= =20 interface to implement SoC-specific successors of standart SDHCI. I'l= l=20 send these patches today (even though I wanted to do a lot more=20 refactoring with them), Peter, could you please test them to find out= if=20 you can use them instead of your SDHCI implementation? --=20 Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsyanko@samsung.com