Re: [Qemu-devel] [PATCH 3/9] Print out progress when checking compiler flags

[Stefan Weil <sw@weilnetz.de>]

Am 02.04.2012 12:50, schrieb Daniel P. Berrange:
> From: "Daniel P. Berrange"<berrange@redhat.com>
>
> Normal practice for autoconf style scripts is to print out
> progress. The QEMU configure script is getting increasingly
> slow&  has no progress feedback. Print out the progress of
> checking each compiler flag
>
> Signed-off-by: Daniel P. Berrange<berrange@redhat.com>
> ---
>   configure |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/configure b/configure
> index 64ab4dc..44b28c8 100755
> --- a/configure
> +++ b/configure
> @@ -1170,8 +1170,12 @@ int main(void) { return 0; }
>   EOF
>   warning_flags=
>   for flag in $gcc_flags; do
> +    echo -n "checking if $cc supports $flag... "
>       if compile_prog "-Werror $warning_flags $flag" "" ; then
>   	warning_flags="$warning_flags $flag"
> +	echo "yes"
> +    else
> +	echo "no"
>       fi
>   done
>   QEMU_CFLAGS="$QEMU_CFLAGS $warning_flags"

This is not needed if we check all flags in a single step
(see my comment to patch 1/9).

IMHO, configure should not print progress feedback by default.