From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47996)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SEkQb-0002SC-9D
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 12:48:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SEkQS-0004GR-Sj
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 12:48:24 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:59019)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SEkQS-0004G7-M7
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 12:48:16 -0400
Message-ID: <4F79D849.2030300@weilnetz.de>
Date: Mon, 02 Apr 2012 18:48:09 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1333363816-1691-1-git-send-email-berrange@redhat.com>
	<1333363816-1691-10-git-send-email-berrange@redhat.com>
In-Reply-To: <1333363816-1691-10-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 9/9] Add note about some other
 options	potentially worth enabling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

Am 02.04.2012 12:50, schrieb Daniel P. Berrange:
> From: "Daniel P. Berrange" <berrange@redhat.com>
>
> There are a few other GCC warning options likely worth
> enabling, but it is not practical with the level of warnings
> generated. Add a note about them for anyone motiviated to
> address it in the future
>
> * configure: Add -Wclobbered, -Wmissing-field-initializers,
> -Woverride-init, -Wsign-compare, -Wunused-parameter,
> -Wunused-but-set-parameter, -Wpointer-arith, -Wmissing-noreturn,
> -Wjump-misses-init but leave disabled for now
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> configure | 20 ++++++++++++++++++++
> 1 files changed, 20 insertions(+), 0 deletions(-)
>
> diff --git a/configure b/configure
> index 175901f..2d62337 100755
> --- a/configure
> +++ b/configure
> @@ -1199,6 +1199,26 @@ gcc_flags="$gcc_flags -Wformat-extra-args"
> gcc_flags="$gcc_flags -Wformat-zero-length"
> gcc_flags="$gcc_flags -Wformat-nonliteral"
>
> +# Some other potentially worth enabling once issues are fixed
> +# False positives in cpu-exec.c
> +#gcc_flags="$gcc_flags -Wclobbered"
> +# Many many violations
> +#gcc_flags="$gcc_flags -Wmissing-field-initializers"
> +# Quite a few (intentional?) overrides
> +#gcc_flags="$gcc_flags -Woverride-init"
> +# Many many violations
> +#gcc_flags="$gcc_flags -Wsign-compare"
> +# Many many violations
> +#gcc_flags="$gcc_flags -Wunused-parameter"
> +# Strange violations in mips helper
> +#gcc_flags="$gcc_flags -Wunused-but-set-parameter"

Well, those violations in the MIPS code are not strange:
they are simply errors in the code, so that comment should
say "Bugs in mips helper".

By the way, I also frequently compile with additional warnings
and use -Wextra (and -Wno-xxx for those errors which I don't
want to see because there are many many violations :-)).
That's how I found the MIPS errors - a patch was sent and is
waiting for reviewers (http://patchwork.ozlabs.org/patch/144478/).

Cheers,
Stefan W.