From: Antti Palosaari <crope@iki.fi>
To: "Michael Büsch" <m@bues.ch>
Cc: linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH] af9035: Add fc0011 tuner support
Date: Mon, 02 Apr 2012 20:03:08 +0300 [thread overview]
Message-ID: <4F79DBCC.6070803@iki.fi> (raw)
In-Reply-To: <20120402181836.0018c6ad@milhouse>
On 02.04.2012 19:18, Michael Büsch wrote:
> This adds Fitipower fc0011 tuner support to the af9035 driver.
>
> Signed-off-by: Michael Buesch<m@bues.ch>
Applied, thanks!
http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/af9035_experimental
And same checkpatch.pl issue here.
You can ran checkpatch like that:
git diff | ./scripts/checkpatch.pl -
git diff --cached | ./scripts/checkpatch.pl -
./scripts/checkpatch.pl --file drivers/media/dvb/dvb-usb/af9035.c
For that driver it complains you are using wrong sleep (msleep(10)).
Correct sleep for that case is something like usleep_range(10000,
100000); which means as sleep at least 10ms but it does not matter if
you sleep even 100ms. The wider range the better chance for Kernel to
optimize power saving. There was usleep_range() already used inside that
module.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2012-04-02 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 16:18 [PATCH] af9035: Add fc0011 tuner support Michael Büsch
2012-04-02 17:03 ` Antti Palosaari [this message]
2012-04-02 17:24 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F79DBCC.6070803@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=m@bues.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.