From: Larry Finger <Larry.Finger@lwfinger.net>
To: Forest Bond <forest@alittletooquiet.net>
Cc: linux-wireless@vger.kernel.org, Chaoming Li <chaoming_li@realsil.com.cn>
Subject: Re: [PATCH 1/2] rtl8192de: Clean up and fix 92D cut version constants and macros.
Date: Mon, 02 Apr 2012 13:04:08 -0500 [thread overview]
Message-ID: <4F79EA18.9060502@lwfinger.net> (raw)
In-Reply-To: <20120402175745.GE20611@alittletooquiet.net>
On 04/02/2012 12:57 PM, Forest Bond wrote:
> Hi Larry,
>
> On Mon, Apr 02, 2012 at 12:54:01PM -0500, Larry Finger wrote:
>> On 04/02/2012 09:25 AM, Forest Bond wrote:
>>> From: Forest Bond<forest.bond@rapidrollout.com>
>>>
>>> The previous definitions included both {B,C,D,E}_CUT_VERSION and
>>> CHIP_92D_{C,D}_CUT with conflicting values for the C and D cut versions,
>>> and literal hex values were used in the IS_92D_{C,D,E}_CUT macros. So
>>> we clean all this up and in doing so enable cut-specific code paths for
>>> cuts C and D, which would not have been executed because the
>>> CHIP_92D_{C,D}_CUT constants were wrong and the cut version was thus
>>> recorded incorrectly.
>>>
>>> Signed-off-by: Forest Bond<forest.bond@rapidrollout.com>
>>
>> This patch does not apply to the wireless-testing tree. That is the
>> one you are supposed to use.
>>
>> Patch #2 also fails to apply. In addition, your mailer mangled a line.
>
> Sorry for the trouble. I'll resend a little later this afternoon.
No problem for me. I was able to fix everything but the mangling with wiggle.
Larry
next prev parent reply other threads:[~2012-04-02 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 14:25 [PATCH 1/2] rtl8192de: Clean up and fix 92D cut version constants and macros Forest Bond
2012-04-02 15:46 ` Larry Finger
2012-04-02 17:54 ` Larry Finger
2012-04-02 17:57 ` Forest Bond
2012-04-02 18:04 ` Larry Finger [this message]
2012-04-05 18:06 ` Forest Bond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F79EA18.9060502@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=forest@alittletooquiet.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.