From: stefano babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Correct corrupted NAND Flash access on KARO TX25 modules
Date: Mon, 02 Apr 2012 20:18:10 +0200 [thread overview]
Message-ID: <4F79ED62.5040303@denx.de> (raw)
In-Reply-To: <7605B15734F74B40A124AED46B25250A4F2809@HEFRMBX01.sofr.hefr.lan>
Am 02/04/2012 19:47, schrieb Gachet Daniel:
> Hi Stefano,
>
> Have I to do more for the patch? Are you ok with the proposal?
>
That is ok. Please use a shorter name: the function you patch is already
surrounded by #ifdef MXC_NFC_V1_1, so it is not required to repeat it in
the name (we have a lot of long names, but
CONFIG_NAND_MXC_V1_1_NFC_ONE_CYCLE is really quite long). The name
suggest also that you want to set ONE_CYCLE, but really you want the
opposite. Something like CONFIG_NAND_MXC_NO_ONE_CYLE is still long, but
maybe more correct.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2012-04-02 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 7:31 [U-Boot] [PATCH] Correct corrupted NAND Flash access on KARO TX25 modules Gachet Daniel
2012-03-31 18:31 ` Marek Vasut
2012-04-01 8:56 ` Gachet Daniel
2012-04-01 13:43 ` Marek Vasut
2012-04-01 10:33 ` stefano babic
2012-04-01 19:09 ` Gachet Daniel
2012-04-01 21:02 ` Marek Vasut
[not found] ` <7605B15734F74B40A124AED46B25250A4F26AD@HEFRMBX01.sofr.hefr.lan>
2012-04-02 13:39 ` Marek Vasut
[not found] ` <7605B15734F74B40A124AED46B25250A4F2809@HEFRMBX01.sofr.hefr.lan>
2012-04-02 18:18 ` stefano babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F79ED62.5040303@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.