From: Michal Marek <mmarek@suse.cz>
To: Andrej Krutak <andree@andree.sk>
Cc: linux-kbuild@vger.kernel.org, Jon Loeliger <jdl@jdl.com>
Subject: Re: [PATCH] Fix build failure on cygwin.
Date: Mon, 02 Apr 2012 23:31:18 +0200 [thread overview]
Message-ID: <4F7A1AA6.8000702@suse.cz> (raw)
In-Reply-To: <1333375535-6589-1-git-send-email-andree@andree.sk>
Adding Jon Loeliger (dtc maintainer) to CC.
Dne 2.4.2012 16:05, Andrej Krutak napsal(a):
> The _B macro is defined by cygwin in ctype.h.
> Move the inclusion to avoid build failure.
But nothing prevents the other system headers from including <ctype.h>
earlier :-(. A more robust fix would be to rename the macro to something
that does not clash (fdt_b??). But that's up to Jon.
Michal
>
> Signed-off-by: Andrej Krutak <andree@andree.sk>
> ---
> scripts/dtc/dtc.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/dtc/dtc.h b/scripts/dtc/dtc.h
> index f37c97e..7aa3cc6 100644
> --- a/scripts/dtc/dtc.h
> +++ b/scripts/dtc/dtc.h
> @@ -27,13 +27,13 @@
> #include <stdint.h>
> #include <stdarg.h>
> #include <assert.h>
> -#include <ctype.h>
> #include <errno.h>
> #include <unistd.h>
>
> #include <libfdt_env.h>
> #include <fdt.h>
>
> +#include <ctype.h>
> #include "util.h"
>
> #ifdef DEBUG
next prev parent reply other threads:[~2012-04-02 21:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 14:05 [PATCH] Fix build failure on cygwin Andrej Krutak
2012-04-02 21:31 ` Michal Marek [this message]
2012-04-02 22:22 ` Jon Loeliger
2012-04-03 6:35 ` [PATCH] Rename _B to _XBYTE in libfdt_env.h Andrej Krutak
2012-04-09 13:49 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7A1AA6.8000702@suse.cz \
--to=mmarek@suse.cz \
--cc=andree@andree.sk \
--cc=jdl@jdl.com \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.