Re: [Qemu-devel] qdev property listing broken

[Paolo Bonzini <pbonzini@redhat.com>]

Il 02/04/2012 22:07, Peter Maydell ha scritto:
> On 2 April 2012 20:40, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
>> index a310cc7..923519c 100644
>> --- a/hw/qdev-monitor.c
>> +++ b/hw/qdev-monitor.c
>> @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts)
>>          * for removal.  This conditional should be removed along with
>>          * it.
>>          */
>> -        if (!prop->info->parse) {
>> +        if (!prop->info->get) {
>>             continue;           /* no way to set it, don't show */
>>         }
> 
> This looks really weird: there's no "get" method so we conclude
> "no way to *set* it" ?? Is the comment wrong?

See the comment above.

Paolo